Skip to content

fix: incorrect type plugin option validation #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2022
Merged

fix: incorrect type plugin option validation #46

merged 1 commit into from
Sep 27, 2022

Conversation

@raae
Copy link
Collaborator

@raae raae commented Sep 27, 2022 •
edited by cloudinary-raae
Loading

type was documented with "all" as the default value. This is the correct mental model as an empty type will result in fetching all types, but setting it to the string "all" will result it an error.

fixes #39

@cloudinary-raae cloudinary-raae merged commit 47d113a into cloudinary-community:main Sep 27, 2022
github-actions bot pushed a commit that referenced this pull request Sep 27, 2022
@semantic-release-bot
chore(release): 0.3.0 [skip ci]
03f7638 
# [0.3.0](v0.2.0...v0.3.0) (2022-09-27)

### Bug Fixes

* incorrect plugin option (type) validation ([#46](#46)) ([47d113a](47d113a)), closes [#39](#39)

### Features

* validation of plugin options ([#45](#45)) ([5ca373b](5ca373b)), closes [#39](#39)
@github-actions
Copy link

github-actions bot commented Sep 27, 2022

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validate configured options using pluginOptionsSchema

2 participants

@raae @cloudinary-raae