Skip to content

Conversation

@error9098x
Copy link
Contributor

Description

Added a guide for configuring a custom domain with svelte-cloudinary, including steps for setting up a private CDN and secure distribution. No additional dependencies required.

Issue Ticket Number

Fixes #143

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: abcd326

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 4, 2024

@error9098x is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple changes, then it's all good! Thank you

@error9098x
Copy link
Contributor Author

Hi @ghostdevv, I have added the suggested changes :)

@vercel
Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-cloudinary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 7:32pm

Copy link
Collaborator

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, ty!

@ghostdevv ghostdevv changed the title Add custom domain guide for svelte-cloudinary configuration #143 docs: add custom domain guide #143 Oct 6, 2024
@ghostdevv ghostdevv merged commit d514ad1 into cloudinary-community:main Oct 6, 2024
5 checks passed
@error9098x
Copy link
Contributor Author

@ghostdevv thanks, can you add hacktoberfest tag in this PR ? this is my first PR during HF :)

@ghostdevv
Copy link
Collaborator

@error9098x it's on the repo don't worry! let me know if it doesn't show up on your hacktoberfest account in a couple days 🙏

@error9098x
Copy link
Contributor Author

@error9098x it's on the repo don't worry! let me know if it doesn't show up on your hacktoberfest account in a couple days 🙏

I just checked, it appeared! 😄 🎊

@colbyfayock
Copy link
Contributor

@error9098x thanks for your contribution. This PR is eligible for free Cloudinary Hacktoberfest swag. Please send me an email to hacktoberfest@cloudinary.com with your name, GitHub username, a link to this PR. Happy Hacktoberfest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a custom domain guide

3 participants