Skip to content

Comments

Add better-docs template to the repo#39

Merged
patrick-tolosa merged 4 commits intomasterfrom
feature/add-jsdoc
Jul 12, 2020
Merged

Add better-docs template to the repo#39
patrick-tolosa merged 4 commits intomasterfrom
feature/add-jsdoc

Conversation

@patrick-tolosa
Copy link
Contributor

No description provided.

@patrick-tolosa patrick-tolosa requested a review from strausr July 8, 2020 08:02
@@ -907,6 +907,16 @@
"@babel/helper-plugin-utils": "^7.8.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete this no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of package lock, related to a bigger question of do we want package.lock or not.

Copy link
Collaborator

@strausr strausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you added the package-lock?

@patrick-tolosa patrick-tolosa merged commit 6380b36 into master Jul 12, 2020
@patrick-tolosa patrick-tolosa deleted the feature/add-jsdoc branch July 16, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants