Skip to content

Video component ignores Transformations #35

@smallstepstoday

Description

@smallstepstoday

Using: React 15.6.2, Cloudinary-React 1.0.4

Using the React example from the documentation I have the following:

import * as React from 'react';
import { shallow } from 'enzyme';
import {Video, Transformation } from 'cloudinary-react';

it('renders the correct url when transformations are specified', () => {
  const video = shallow(
    <Video
      cloudName="dummy-cloud"
      publicId="dog"
    >
      <Transformation quality="50" />
    </Video>
  );
  console.log(video.debug());
  console.log(video.render().html());
});

The debug output is as follows:

<video>
  <source src="http://res.cloudinary.com/dummy-cloud/video/upload/dog.webm" type="video/webm" />
  <source src="http://res.cloudinary.com/dummy-cloud/video/upload/dog.mp4" type="video/mp4" />
  <source src="http://res.cloudinary.com/dummy-cloud/video/upload/dog.ogv" type="video/ogg" />
  <Transformation quality="50" />
</video>

And the final rendered HTML is like so:

<source src="http://res.cloudinary.com/dummy-cloud/video/upload/dog.webm" type="video/webm">
<source src="http://res.cloudinary.com/dummy-cloud/video/upload/dog.mp4" type="video/mp4">
<source src="http://res.cloudinary.com/dummy-cloud/video/upload/dog.ogv" type="video/ogg">

No sign of the expected q_50 in the URL.

Need to have bit_rate, quality and fades for fading in/out.

It's late and it has been a long day, so I am probably doing something wrong. If so, please put an end to my misery. Otherwise, this is a bug!

Best regards,
Dave

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions