Fix responsive prop, add a warning when it's not affecting the transformation #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
asisayag2
reviewed
Jul 10, 2020
| attributes.id = attributes.id + '-cld-placeholder'; | ||
| } | ||
|
|
||
| // Set dataSrc if lazy loading and not in view |
There was a problem hiding this comment.
how is this lazy load part related?
There was a problem hiding this comment.
I needed to update this because i added withCamelCaseKeys().
Comment on lines
9
to
11
| .should('have.attr', 'data-src').should('equal','http://res.cloudinary.com/demo/image/upload/c_scale,w_100/sample') | ||
| cy.get('#responsive-override') | ||
| .should('have.attr', 'src').should('equal','http://res.cloudinary.com/demo/image/upload/c_scale,w_100/sample') |
There was a problem hiding this comment.
really, it should have both?
| cy.visit('/'); | ||
| cy.get('#responsiveBtn').click(); // Click on button | ||
| }); | ||
| it('Responsive Image Override', () => { |
There was a problem hiding this comment.
Can you explain what you mean by "responsive override"?
src/components/Image/Image.js
Outdated
| */ | ||
| isResponsive = () => { | ||
| return this.props.responsive && this.imgElement && this.imgElement.current; | ||
| const {imgElement} = this; |
There was a problem hiding this comment.
Suggested change
| const {imgElement} = this; | |
| const {responsive, width} = this.getExtendedProps(); | |
| if (responsive && width !== 'auto') { | |
| console.warn(WARNING_CONST); | |
| } | |
| return responsive && this.imgElement && this.imgElement.current; |
Comment on lines
+72
to
+74
| if (attributes.dataSrc) { | ||
| attributes['data-src'] = attributes.dataSrc; | ||
| } |
There was a problem hiding this comment.
Looking at this again, calculating a new src isn't required, i've updated this part, please see updated commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #175