feat: schema json exported in build files #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -0,0 +1,523 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
@jakub-roch how do we sync this schema to the actual params of the video player?
if we add a new param to the video player will it be added here or it needs to happen manually?
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
its first step without changing anything inside VP, just a file that is "reference" but its not affecting VP itself
next step would be to change all VP validation to use this file but it requires wider discussion and testing
kalifyaniv-cloudinary
approved these changes
Jul 29, 2025
This was referenced Dec 10, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schema json Video Player