Support different radius for each corner #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzanj
suggested changes
May 27, 2020
|
|
||
| import com.cloudinary.utils.StringUtils; | ||
|
|
||
| public class RadiusOption { |
There was a problem hiding this comment.
This class can be a private (or at most package-private) method in Transformation.
| return StringUtils.join(normalizeRadiusOptions(radiusOption), ":"); | ||
| } | ||
|
|
||
| private static Object[] normalizeRadiusOptions(Object[] radiusOptions) { |
There was a problem hiding this comment.
As most transformation params support explicit string, we (mostly) don't do a lot of validations.
Furthermore - if there is a bad input, we can't just replace it with zeroes.
We should only validate that there are no nulls before calling StringUtils.join(), and remove normalizeRadiusOptions method.
patrick-tolosa
deleted the
feature/add-different-radius-transformation-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.