Skip to content

updateMetadata-pass param "type" #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020
Merged

updateMetadata-pass param "type" #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cloudinary-core/src/main/java/com/cloudinary/Uploader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,7 @@ public Map updateMetadata(Map metadata, String[] publicIds, Map options) throws
Map<String, Object> params = new HashMap<String, Object>();
params.put("metadata", Util.encodeContext(metadata));
params.put("public_ids", Arrays.asList(publicIds));
params.put("type", (String)options.get("type"));

return callApi("metadata", params, options, null);
}
Expand Down
6 changes: 6 additions & 0 deletions cloudinary-test-common/src/main/java/com/cloudinary/test/AbstractStructuredMetadataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
public abstract class AbstractStructuredMetadataTest extends MockableTest {
private static final String METADATA_UPLOADER_TAG = SDK_TEST_TAG + "_uploader";
private static final String PUBLIC_ID = "before_class_public_id" + SUFFIX;
private static final String PRIVATE_PUBLIC_ID = "before_class_private_public_id" + SUFFIX;
protected Api api;
public static final List<String> metadataFieldExternalIds = new ArrayList<String>();

Expand All @@ -29,6 +30,7 @@ public static void setUpClass() throws IOException {
}

cloudinary.uploader().upload(SRC_TEST_IMAGE, asMap("public_id", PUBLIC_ID));
cloudinary.uploader().upload(SRC_TEST_IMAGE, asMap("public_id", PRIVATE_PUBLIC_ID, "type", "private"));
}

@AfterClass
Expand Down Expand Up @@ -226,6 +228,10 @@ public void testUploaderUpdateMetadata() throws Exception {
Map result = cloudinary.uploader().updateMetadata(Collections.<String, Object>singletonMap(fieldId, "123456"), new String[]{PUBLIC_ID}, null);
assertNotNull(result);
assertEquals(PUBLIC_ID, ((List) result.get("public_ids")).get(0).toString());
//test updateMetadata for private asset
Map result2 = cloudinary.uploader().updateMetadata(Collections.<String, Object>singletonMap(fieldId, "123456"), new String[]{PRIVATE_PUBLIC_ID}, asMap("type","private"));
assertNotNull(result);
assertEquals(PRIVATE_PUBLIC_ID, ((List) result2.get("public_ids")).get(0).toString());
}

@Test
Expand Down