Add oauth support to Admin Api calls.
#230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const-cloudinary
requested changes
Jan 12, 2021
| if (oauthToken == null) { | ||
| if (apiKey == null) throw new IllegalArgumentException("Must supply api_key"); | ||
| if (apiSecret == null) throw new IllegalArgumentException("Must supply api_secret"); | ||
| } |
There was a problem hiding this comment.
what if all of them are null?
There was a problem hiding this comment.
If all are null then this is thrown - `IllegalArgumentException("Must supply api_key"). Same behaviour as before for people not using oauth so it doesn't break anything.
const-cloudinary
approved these changes
Jan 12, 2021
asisayag2
approved these changes
Jan 12, 2021
| this.secureCdnSubdomain = secureCdnSubdomain; | ||
| this.useRootPath = useRootPath; | ||
| this.timeout = 0; | ||
| this.timeout = timeout; |
There was a problem hiding this comment.
It's a bugfix (will be in the commit message on merge).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.