Fix version checking in the URL #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontain a version, therefore the version is skipped.
asisayag2
changed the title
const-cloudinary
approved these changes
Oct 5, 2021
| @@ -1,5 +1,5 @@ | |||
| sourceCompatibility = 1.6 | |||
| targetCompatibility = 1.6 | |||
| sourceCompatibility = 1.7 | |||
There was a problem hiding this comment.
Maybe make it a separate commit?
|
@const-cloudinary can we merge this within this same commit? |
@patrick-tolosa , it's not a blocker, we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check whether we should add a version or not used the method
hasVersionStringwhich checks if it contains 'v[num]' anywhere in the string.I changed to check
startWithVersionStringand now it skips the version adding, only if the publicId STARTS with 'v[num]'