Skip to content

Conversation

@nsine
Copy link
Contributor

@nsine nsine commented Jan 21, 2020

All stream upload methods return stream itself, not promise.
This PR fixes typings for them

Copy link
Contributor

@strausr strausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Can you please update package.json to include ts-stream and update cloudinary_ts_spec.ts to expect UploadStream for stream functions?

@nsine
Copy link
Contributor Author

nsine commented Jan 23, 2020

@strausr I think using ts-stream is not necessary. Adding @types/node would be enough for running tests

@nsine
Copy link
Contributor Author

nsine commented Jan 23, 2020

can smb also look at ci? it fails in both of my PRs: this one and #335
what would be the reason?

@nsine nsine requested a review from strausr January 23, 2020 22:31
@asisayag2
Copy link
Contributor

@nsine, thanks for the PR.
We will look into it as soon as possible and this will include making sure the CI is passing.

Copy link
Contributor

@strausr strausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct. Can you please update package.json to include @types/node and update cloudinary_ts_spec.ts to expect UploadStream for stream functions?

@nsine
Copy link
Contributor Author

nsine commented Feb 23, 2020

@strausr hm
but i already did it month ago 😅
41bc0ef

@nsine nsine requested a review from strausr February 23, 2020 19:34
Copy link
Contributor

@strausr strausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsine Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants