-
Couldn't load subscription status.
- Fork 323
fix: type defs for stream upload methods #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type defs for stream upload methods #336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Can you please update package.json to include ts-stream and update cloudinary_ts_spec.ts to expect UploadStream for stream functions?
|
@strausr I think using |
|
can smb also look at ci? it fails in both of my PRs: this one and #335 |
|
@nsine, thanks for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct. Can you please update package.json to include @types/node and update cloudinary_ts_spec.ts to expect UploadStream for stream functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nsine Thanks!!
All stream upload methods return stream itself, not promise.
This PR fixes typings for them