Optimize the video preview #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharsheblows
approved these changes
Apr 15, 2025
Contributor
tharsheblows
left a comment
tharsheblows
left a comment
There was a problem hiding this comment.
Tested and it looks good. The only real changes are in the php/connect/class-api.php and src/css/components/ui/_grid.scss right? And the rest is build.
Collaborator
Author
|
@tharsheblows, yes, that is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes have been applied:
y_andx_video global transformations (note the Cloudinary player doesn't accepty_andx_, they work only for the native browser player).l_text:Times_90_bold:Spring Sale/fl_layer_apply,g_centerQA notes
First issue:
l_logo,g_north_east,w_100,h_60,y_100,x_20y_100, andx_20should be available in the link (example:demo/video/upload/f_auto,q_auto/l_logo,g_north_east,w_100,h_60,y_100,x_20/dog.mp4(previously they were excluded).Second issue:
l_text:Times_90_bold:Spring Sale/fl_layer_apply,g_center