Add __isset() method to Relationship class
#1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, calling `isset()` on an overloaded property accessed via the magic `__get()` method, like `public_id` returns `false`, even if it is set.
acrobertson
changed the title
isset() method to Relationship class__isset() method to Relationship class
Contributor
|
@acrobertson, Thank you for your contribution and for preparing a PR for the submitted issue. The code changes look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1049
Approach
This adds a magic
__isset()method to theCloudinary\Relate\Relationshipclass to complement the existing__get()and__set()methods.Without this, calling
isset()on an overloaded property likepublic_idreturnsfalse, even when it is in fact set.QA notes
Following the reproduction steps in the linked issue, calling
isset()on an overloaded property of aRelationshipinstance should now returntrueif it has a value in the$data_cache.