Skip to content

Prevent trying to replace a video when there is not a Cloudinary URL #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Prevent trying to replace a video when there is not a Cloudinary URL #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/media/class-video.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,19 +308,23 @@ public function filter_video_tags( $content ) {
$overwrite_transformations = true;
}
$cloudinary_url = $this->media->cloudinary_url( $attachment_id, false, false, null, $overwrite_transformations );
$transformations = $this->media->get_transformations_from_string( $cloudinary_url, 'video' );
if ( ! empty( $transformations ) ) {
$args['transformation'] = $transformations;
}
$video = wp_get_attachment_metadata( $attachment_id );
if ( $this->player_enabled() ) {
$instance = $this->queue_video_config( $attachment_id, $url, $video['fileformat'], $args );
// Remove src and replace with an ID.
$new_tag = str_replace( 'src="' . $url . '"', 'id="cloudinary-video-' . esc_attr( $instance ) . '"', $tag );
$content = str_replace( $tag, $new_tag, $content );
} else {
// Just replace URL.
$content = str_replace( $url, $cloudinary_url, $content );
// Bail replacing the video URL for cases where it doesn't exist.
// Cases are, for instance, when the file size is larger than the API limits — free accounts.
if ( ! empty( $cloudinary_url ) ) {
$transformations = $this->media->get_transformations_from_string( $cloudinary_url, 'video' );
if ( ! empty( $transformations ) ) {
$args['transformation'] = $transformations;
}
$video = wp_get_attachment_metadata( $attachment_id );
if ( $this->player_enabled() ) {
$instance = $this->queue_video_config( $attachment_id, $url, $video['fileformat'], $args );
// Remove src and replace with an ID.
$new_tag = str_replace( 'src="' . $url . '"', 'id="cloudinary-video-' . esc_attr( $instance ) . '"', $tag );
$content = str_replace( $tag, $new_tag, $content );
} else {
// Just replace URL.
$content = str_replace( $url, $cloudinary_url, $content );
}
}
}

Expand Down