Fix cron-run.txt PHP warning #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielcld2
reviewed
Jul 18, 2025
| $data = file_get_contents( $lock_file ); // phpcs:ignore WordPressVIPMinimum.Performance.FetchingRemoteData.FileGetContentsUnknown | ||
|
|
||
| if ( ! file_exists( $lock_file ) ) { | ||
| return ''; |
Collaborator
There was a problem hiding this comment.
question: Do we risk encountering another PHP warning when this is called? I noticed this function is called in this place right now https://github.com/cloudinary/cloudinary_wordpress/blob/master/php/class-cron.php#L392-L394
and that function is doing a foreach, which on an empty string would return a PHP warning. Not sure how to replicate this scenario though.
Perhaps we can simply add another check before that foreach?
Collaborator
Author
There was a problem hiding this comment.
Hi @gabrielcld2, thank you for that. I agree, and added the additional check.
gabriel-detassigny
approved these changes
Jul 20, 2025
gabrielcld2
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this PHP warning:
Approach
file_get_contentsis used when the file exists.QA notes
/wp-admin/admin.php?page=cloudinary§ion=cron_systemdebug.log