ltrim forward slashes on public ID #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A public ID cannot start with a forward slash.
If the folder is set to none, it defaults to
/Previously, this was not an issue since we didn't build the folder/public_id structure dynamically. But now, since it is, a root folder asset will start with/. i.e/public-id-jpgThis fix simply applies a
ltrim( $public_id, '/' )when combining the folder and id.An additional fix is that if
auto-uploadis disabled, assets that go out of sync, (changing the folder, or cloudname, etc...) it will show as unsynced. This is because there is a check to see if auto sync is on before uploading. I've added a check to see if it's off unless it's been synced before. if it has, it enables it for just that asset.