New sync status #123
Merged
New sync status #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dugajean
reviewed
Jul 17, 2020
Comment on lines
+395
to
+396
| delete_post_meta( $post->ID, Sync::META_KEYS['syncing'] ); | ||
| delete_post_meta( $post->ID, Sync::META_KEYS['downloading'] ); |
Contributor
There was a problem hiding this comment.
These two lines are repeated quite a bit, so maybe it'd be good to extract this into a method 😉
function clear_attachment_status( $attachment_id ) { ... }
dugajean
approved these changes
Jul 17, 2020
Contributor
dugajean
left a comment
dugajean
left a comment
There was a problem hiding this comment.
Very clean implementation. Approved 👍
This was referenced Apr 28, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 new status for assets.