Skip to content

Conversation

@dugajean
Copy link
Contributor

Test instructions:

  • Install WPBakery
  • Insert Cloudinary images in a post using WPBakery editor
  • Observe console and notice absence of errors

@DavidCramer
Copy link
Contributor

Thanks for this @dugajean - I'm curious to know, what happens if the attach isn't available? How is it handled?

@dugajean
Copy link
Contributor Author

dugajean commented Jul 22, 2020

@DavidCramer In such a case, it's not possible to use transformations. WPBBakery is somehow messing with these lines:

let state  = wp.media.editor.get().state();
let attach = state.get( 'selection' ).get( data.attachment );

The state with WPBakery enabled results in the selection state to be missing. The only options I see available here is error prevention or disabling WPBakery entirely.

@DavidCramer
Copy link
Contributor

@dugajean - So does this only happen when you import an image from cloudinary that has a transformation?

@dugajean
Copy link
Contributor Author

@DavidCramer I've to check that out. But my guess would be that it happens every time.

@pereirinha pereirinha force-pushed the fix/wpbakery-insert-error branch from cf4e5de to b36f090 Compare October 27, 2020 11:29
Copy link
Contributor

@pereirinha pereirinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dugajean
Let's move this forward.

@pereirinha pereirinha merged commit 60347d1 into develop Oct 27, 2020
@pereirinha pereirinha deleted the fix/wpbakery-insert-error branch November 12, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants