Feature/unique-filenames #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pereirinha
suggested changes
Jul 23, 2020
Contributor
pereirinha
left a comment
pereirinha
left a comment
There was a problem hiding this comment.
I left you a few comments and questions to weight.
Let me know what do you think.
Great approach overall ;)
Thank you.
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-sync.php
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-sync.php
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-sync.php
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-sync.php
Outdated
Show resolved
Hide resolved
dugajean
approved these changes
Jul 23, 2020
Contributor
dugajean
left a comment
dugajean
left a comment
There was a problem hiding this comment.
Once Marco's remarks are implemented, this one is good to go!
pereirinha
approved these changes
Jul 24, 2020
Contributor
pereirinha
left a comment
pereirinha
left a comment
There was a problem hiding this comment.
Great work @DavidCramer
Thanks for putting this solution together.
Contributor
Author
|
@pereirinha - Please give this another review. I've made some changes that make this way better and allows the public_id to be filtered freely. |
pereirinha
approved these changes
Jul 27, 2020
Contributor
pereirinha
left a comment
pereirinha
left a comment
There was a problem hiding this comment.
This looks great.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.