Skip to content

Fix/parse error in settings #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Fix/parse error in settings #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdbfb39
remove comma and cleanup formatting
DavidCramer Jul 27, 2020
0bfa56f
cleanup formatting
DavidCramer Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...nipulation-in-the-cloud-cdn/ui-definitions/tabs/settings-global-video-transformations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,23 +48,23 @@
),
),
'video_autoplay_mode' => array(
'label' => null,
'prefix' => __( 'Autoplay:', 'cloudinary' ),
'type' => 'select',
'default' => 'never',
'choices' => array(
'label' => null,
'prefix' => __( 'Autoplay:', 'cloudinary' ),
'type' => 'select',
'default' => 'never',
'choices' => array(
'off' => __( 'Off', 'cloudinary' ),
'always' => __( 'Always', 'cloudinary' ),
'on-scroll' => __( 'On-Scroll (Autoplay when in view)', 'cloudinary' ),
),
'condition' => array(
'condition' => array(
'video_player' => 'cld',
),
'description' => sprintf(
'description' => sprintf(
// translators: Placeholders are <a> tags.
__( 'Please note that when choosing "always", the video will autoplay without sound (muted). This is a built-in browser feature and applies to all major browsers.%1$sRead more about muted autoplay%2$s', 'cloudinary' ),
'<br><a href="https://developers.google.com/web/updates/2016/07/autoplay" target="_blank">',
'</a>',
'</a>'
),
),

Expand Down