add check that a synctype is still available #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dugajean
reviewed
Aug 11, 2020
| public function filter_status( $status, $attachment_id ) { | ||
|
|
||
| if ( $this->been_synced( $attachment_id ) || $this->is_pending( $attachment_id ) ) { | ||
| if ( $this->been_synced( $attachment_id ) && $this->is_pending( $attachment_id ) && $this->get_sync_type( $attachment_id ) ) { |
Contributor
There was a problem hiding this comment.
Calling get_sync_type outside the if may be a better idea to avoid calling the same function multiple times
Contributor
Author
There was a problem hiding this comment.
@dugajean - a good observation, but at this point, the get_sync_type will be using the cached version (the cache flag is not set to false), meaning it will be run once on the page load. So it should represent the state at time of load.
pereirinha
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pereirinha - the metadata on whats saved (pending, syncing etc) may be outdated. If there is no sync-type needed due to the signature being in sync and up to date, don't show meta data notices, since it's no longer relevant.