CNAME regression fix #177
Merged
CNAME regression fix #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dugajean
force-pushed
the
fix/cname-regression
branch
from
bfa6616 to
d79d45d
Compare
DavidCramer
suggested changes
Sep 1, 2020
Contributor
DavidCramer
left a comment
DavidCramer
left a comment
There was a problem hiding this comment.
Thanks for the quick work here @dugajean. Works great.
Just a few cleanups to do with alignments and standards.
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-connect.php
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-connect.php
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-connect.php
Show resolved
Hide resolved
Co-authored-by: David Cramer <david.cramer@xwp.co>
Co-authored-by: David Cramer <david.cramer@xwp.co>
Co-authored-by: David Cramer <david.cramer@xwp.co>
DavidCramer
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.