Reset folder #219
Merged
Reset folder #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dugajean
reviewed
Sep 25, 2020
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-media.php
Outdated
Show resolved
Hide resolved
dugajean
reviewed
Sep 25, 2020
Contributor
dugajean
left a comment
dugajean
left a comment
There was a problem hiding this comment.
Great work! Works as expected. Left a few comments to check out before moving forward. 👍
dugajean
reviewed
Sep 25, 2020
| * | ||
| * @return bool | ||
| */ | ||
| && ! apply_filters( 'cloudinary_doing_upload', false ) |
Contributor
There was a problem hiding this comment.
One small correction here:
Suggested change
| && ! apply_filters( 'cloudinary_doing_upload', false ) | |
| && apply_filters( 'cloudinary_doing_upload', false ) |
Otherwise we default to true. Thanks for addressing this 😁
Contributor
Author
There was a problem hiding this comment.
The default should be true. We should almost always resolve to serve the Cloudinary. However, in the case of uploading, we should bail any change.
DavidCramer
approved these changes
Sep 29, 2020
Contributor
DavidCramer
left a comment
DavidCramer
left a comment
There was a problem hiding this comment.
This looks good to me. It's a nice addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows pushing an asset update — either via
Re-sync to Cloudinaryor the bulk actionPush to Cloudinary— that resets the location of the asset in Cloudinary account to the folder set in WordPress.