Skip to content

Fixes i18n namespacing #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2020
Merged

Fixes i18n namespacing #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
696e214
Add test version
Nov 30, 2020
0fa0e46
Make sure to include textdomain
Nov 30, 2020
5cd5e48
Add text domain
Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion php/class-plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ public function force_visit_plugin_site_link( $plugin_meta, $plugin_file, $plugi
$plugin_site_link = sprintf(
'<a href="%s">%s</a>',
esc_url( $plugin_data['PluginURI'] ),
__( 'Visit plugin site' )
__( 'Visit plugin site', 'cloudinary' )
);
if ( ! in_array( $plugin_site_link, $plugin_meta, true ) ) {
$plugin_meta[] = $plugin_site_link;
Expand Down
2 changes: 1 addition & 1 deletion php/class-settings-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ public function footer() {
*/
public function get_ui() {
$defaults = array(
'save_button_label' => __( 'Save Changes' ),
'save_button_label' => __( 'Save Changes', 'cloudinary' ),
'capability' => 'manage_options',
'tabs' => array(),
);
Expand Down
9 changes: 9 additions & 0 deletions phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<?xml version="1.0"?>
<ruleset name="WordPress coding standards">
<!-- Check for cross-version support for PHP 5.6 and higher. -->
<config name="testVersion" value="5.6-"/>

<config name="ignore_warnings_on_exit" value="1" /><!-- Ignore warnings for now. -->

<file>.</file><!-- Lint all PHP files by default. -->
Expand All @@ -12,6 +15,12 @@
<!-- Includes WordPress-Core, WordPress-Docs and WordPress-Extra rulesets. -->
<rule ref="WordPress" />

<rule ref="WordPress.WP.I18n">
<properties>
<property name="text_domain" type="array" value="cloudinary" />
</properties>
</rule>

<!-- Include WP VIP coding standard checks -->
<rule ref="WordPress-VIP-Go" />
<rule ref="WordPressVIPMinimum" />
Expand Down
2 changes: 1 addition & 1 deletion ui-definitions/tabs/dashboard-content.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
<p><span class="dashicons dashicons-image-crop"></span> <?php echo wp_kses_post( $manage_text ); ?></p>
<?php endif; ?>
<p><span class="dashicons dashicons-welcome-learn-more"></span>
<a href="https://cloudinary.com/documentation/wordpress_integration" target="_blank"> <?php esc_html_e( 'Learn more about getting started' ); ?></a></p>
<a href="https://cloudinary.com/documentation/wordpress_integration" target="_blank"> <?php esc_html_e( 'Learn more about getting started', 'cloudinary' ); ?></a></p>
</div>
</div>
<?php if ( ! empty( $video_url ) ) : ?>
Expand Down
4 changes: 2 additions & 2 deletions ui-definitions/tabs/settings-global-transformations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
'enable_breakpoints' => true,
),
// translators: Placeholders are numerical ranges or min and max.
'suffix' => sprintf( __( 'Valid values: %1$d – %2$d.' ), 3, 200 ),
'suffix' => sprintf( __( 'Valid values: %1$d – %2$d.', 'cloudinary' ), 3, 200 ),
),
'bytes_step' => array(
'label' => __( 'Byte step', 'cloudinary' ),
Expand Down Expand Up @@ -144,7 +144,7 @@
'contextual' => true, // Flags the field to be used in a contextual basis. i.e. taxonomies.
'context' => 'image',
'sanitize_callback' => 'trim',
'error_notice' => __( 'Format and Quality cannot be used in free form.' ),
'error_notice' => __( 'Format and Quality cannot be used in free form.', 'cloudinary' ),
'type' => 'textarea',
),
'image_preview' => array(
Expand Down
2 changes: 1 addition & 1 deletion ui-definitions/tabs/settings-global-video-transformations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
'contextual' => true, // Flags the field to be used in a contextual basis. i.e. taxonomies.
'context' => 'video',
'sanitize_callback' => 'trim',
'error_notice' => __( 'Format and Quality cannot be used in free form.' ),
'error_notice' => __( 'Format and Quality cannot be used in free form.', 'cloudinary' ),
),
'video_preview' => array(
'label' => __( 'Preview', 'cloudinary' ),
Expand Down