Settings UI #278
Merged
Settings UI #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 10, 2020 16:04
DavidCramer
suggested changes
Dec 14, 2020
Contributor
DavidCramer
left a comment
DavidCramer
left a comment
There was a problem hiding this comment.
@pereirinha , in general, this is all cool.
I do however see some issues on styling in screen sizes lower full HD.
at 1440 the text wraps, as per the screen shot below. (perhaps reduce the font size just a little...)
Contributor
Author
|
Thanks for catching that. I've updated the PR and fixed the conflicts with |
DavidCramer
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds the plan status component and fixes minor issues.