Skip to content

Prevent an error in WP 4.9.12 from field sanitization #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Prevent an error in WP 4.9.12 from field sanitization #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-settings-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,18 @@ public function sanitize( $setting, $fields ) {
}
} else {
if ( is_array( $field ) ) {
array_walk_recursive( $field, 'sanitize_text_field' );
array_walk_recursive(
$field,
static function( $field_value ) {
// WP 4.9 compatibility, as _sanitize_text_fields() didn't have this check yet, and this prevents an error.
// @see https://github.com/WordPress/wordpress-develop/blob/b30baca3ca2feb7f44b3615262ca55fcd87ae232/src/wp-includes/formatting.php#L5307
if ( is_object( $field_value ) || is_array( $field_value ) ) {
return '';
}

return sanitize_text_field( $field_value );
}
);
} else {
$setting[ $slug ] = sanitize_text_field( $field );
}
Expand Down