Skip to content

default meta key as string #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021
Merged

default meta key as string #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions php/class-media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1824,13 +1824,13 @@ public function get_transformation_from_meta( $post_id ) {
/**
* Get Cloudinary related Post meta.
*
* @param int $post_id The attachment ID.
* @param string|null $key The meta key to get.
* @param bool $single If single or not.
* @param int $post_id The attachment ID.
* @param string $key The meta key to get.
* @param bool $single If single or not.
*
* @return mixed
*/
public function get_post_meta( $post_id, $key = null, $single = false ) {
public function get_post_meta( $post_id, $key = '', $single = false ) {

$meta_data = wp_get_attachment_metadata( $post_id, true );
if ( ! is_array( $meta_data ) ) {
Expand All @@ -1840,7 +1840,7 @@ public function get_post_meta( $post_id, $key = null, $single = false ) {
$meta_data[ Sync::META_KEYS['cloudinary'] ] = array();
}

if ( null === $key ) {
if ( '' === $key ) {
$data = $meta_data[ Sync::META_KEYS['cloudinary'] ];
} elseif ( ! empty( $meta_data[ Sync::META_KEYS['cloudinary'] ][ $key ] ) ) {
$data = $meta_data[ Sync::META_KEYS['cloudinary'] ][ $key ];
Expand Down