Skip to content

Fixes bug that causes Cloudinary videos to appear cut #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fixes bug that causes Cloudinary videos to appear cut #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/media/class-video.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,6 @@ public function print_video_scripts() {
cld.videoPlayer( cldId, cldConfig );
}

<?php if ( $this->config['video_freeform'] ): ?>
window.addEventListener( 'load', function() {
for ( var videoInstance in cldVideos ) {
var cldId = 'cloudinary-video-' + videoInstance;
Expand All @@ -370,16 +369,18 @@ public function print_video_scripts() {

if ( videoElement.length === 1 ) {
videoElement = videoElement[0];
videoElement.style.width = '100%';

<?php if ( $this->config['video_freeform'] ): ?>
videoElement.src = videoElement.src.replace(
'upload/',
'upload/<?php echo esc_js( $this->config['video_freeform'] ) ?>/'
);
<?php endif ?>
}
}
} );
<?php
endif;

<?php
$script = ob_get_clean();

wp_add_inline_script(
Expand Down