Skip to content

Fix/CLOUD-371 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fix/CLOUD-371 #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/media/class-video.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,21 @@ public function filter_video_shortcode( $html, $attr ) {
if ( false === $this->player_enabled ) {
return $html;
};

// Queue video.
$video = wp_get_attachment_metadata( $attr['id'] );
// Check for override flag.
$overwrite_transformations = false;
if ( ! empty( $attr['cldoverwrite'] ) ) {
$overwrite_transformations = true;
}
$cloudinary_url = $this->media->cloudinary_url( $attr['id'], false, false, null, $overwrite_transformations );
// Check for a cloudinary url, or prep sync if not found.
$cloudinary_url = $this->media->cloudinary_url( $attr['id'], false, false, null, $overwrite_transformations );
if ( ! $this->media->plugin->components['sync']->is_synced( $attr['id'] ) ) {
// If the asset is not synced, then the metadata will not be complete since v1 didn't save any.
// Return html for now since cloudinary_url will queue it up for syncing in the background.
return $html;
}

// Queue video.
$video = wp_get_attachment_metadata( $attr['id'] );
$transformations = $this->media->get_transformations_from_string( $cloudinary_url, 'video' );
$args = array();

Expand Down