Skip to content

The cloudinary_id is either null or string #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2021
Merged

The cloudinary_id is either null or string #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion php/class-media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ protected function get_cache_key( $args ) {
* @param int $attachment_id The id of the attachment.
* @param array|string $size The wp size to set for the URL.
* @param array $transformations Set of transformations to apply to this url.
* @param string $cloudinary_id Optional forced cloudinary ID.
* @param string|null $cloudinary_id Optional forced cloudinary ID.
* @param bool $overwrite_transformations Flag url is a breakpoint URL to stop re-applying default transformations.
*
* @return string The converted URL.
Expand Down
2 changes: 1 addition & 1 deletion php/delivery/class-lazy-load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public function add_features( $tag_element, $attachment_id, $original_tag ) {
}
$src = $tag_element['atts']['src'];
if ( ! $this->media->is_cloudinary_url( $src ) ) {
$src = $this->media->cloudinary_url( $attachment_id, array(), array(), array(), $tag_element['cld-overwrite'] );
$src = $this->media->cloudinary_url( $attachment_id, array(), array(), null, $tag_element['cld-overwrite'] );
}
$tag_element['atts']['data-src'] = $src;
$transformations = $this->media->get_transformations_from_string( $src );
Expand Down
2 changes: 1 addition & 1 deletion php/delivery/class-responsive-breakpoints.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ protected function setup_hooks() {
public function add_features( $tag_element, $attachment_id, $original_tag ) {

if ( ! $this->media->is_cloudinary_url( $tag_element['atts']['src'] ) ) {
$tag_element['atts']['src'] = $this->media->cloudinary_url( $attachment_id, array(), array(), array(), $tag_element['cld-overwrite'] );
$tag_element['atts']['src'] = $this->media->cloudinary_url( $attachment_id, array(), array(), null, $tag_element['cld-overwrite'] );
}
$transformations = $this->media->get_transformations_from_string( $tag_element['atts']['src'] );
$original_string = Api::generate_transformation_string( $transformations );
Expand Down