Skip to content

dont capture on REST, check if content is empty #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022
Merged

dont capture on REST, check if content is empty #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions php/class-string-replace.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,16 @@ protected function admin_filters() {
*/
protected function public_filters() {
add_action( 'template_include', array( $this, 'init_debug' ), PHP_INT_MAX );
add_action( 'parse_request', array( $this, 'init' ), - 1000 ); // Not crazy low, but low enough to catch most cases, but not too low that it may break AMP.
if ( ! defined( 'REST_REQUEST' ) || ! REST_REQUEST ) { // Not needed on REST API.
add_action( 'parse_request', array( $this, 'init' ), - 1000 ); // Not crazy low, but low enough to catch most cases, but not too low that it may break AMP.
}
}

/**
* Add filters for REST API.
*/
protected function add_rest_filters() {
$types = get_post_types_by_support( 'author' );
$types = get_post_types();
foreach ( $types as $type ) {
$post_type = get_post_type_object( $type );
// Check if this is a rest supported type.
Expand Down Expand Up @@ -255,7 +257,7 @@ public function replace_strings( $content, $context = 'view' ) {
}
if ( Utils::looks_like_json( $content ) ) {
$json_maybe = json_decode( $content, true );
if ( $json_maybe ) {
if ( ! empty( $json_maybe ) ) {
$content = $json_maybe;
}
}
Expand All @@ -264,7 +266,8 @@ public function replace_strings( $content, $context = 'view' ) {
$content = self::do_replace( $content );
}
self::reset();
$last_content = isset( $json_maybe ) ? wp_json_encode( $content ) : $content;
$last_content = ! empty( $json_maybe ) ? wp_json_encode( $content ) : $content;

return $last_content;
}

Expand Down