Skip to content

Include the cld_param transformations on default breakpoints #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

Include the cld_param transformations on default breakpoints #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions php/class-delivery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,6 +1075,7 @@ public function rebuild_tag( $tag_element ) {
// Check overwrite.
$meta['overwrite_transformations'] = $tag_element['overwrite_transformations'];
$meta['cloudinary_id'] = $tag_element['atts']['data-public-id'];
$meta['transformations'] = $tag_element['transformations'];
// Add new srcset.
$element = wp_image_add_srcset_and_sizes( $tag_element['original'], $meta, $tag_element['id'] );

Expand Down
9 changes: 7 additions & 2 deletions php/class-media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1707,9 +1707,14 @@ public function image_srcset( $sources, $size_array, $image_src, $image_meta, $a
return $sources; // Return WordPress default sources.
}
// Get transformations if any.
$transformations = $this->get_post_meta( $attachment_id, Sync::META_KEYS['transformation'], true );
// Use Cloudinary breakpoints for same ratio.
$transformations = (array) $this->get_post_meta( $attachment_id, Sync::META_KEYS['transformation'], true );

// For cases where transformations are added via cld_params.
if ( ! empty( $image_meta['transformations'] ) ) {
$transformations = array_filter( array_merge( $transformations, $image_meta['transformations'] ) );
}

// Use Cloudinary breakpoints for same ratio.
$image_meta['overwrite_transformations'] = ! empty( $image_meta['overwrite_transformations'] ) ? $image_meta['overwrite_transformations'] : false;

if ( 'on' === $this->settings->get_setting( 'enable_breakpoints' )->get_value() && wp_image_matches_ratio( $image_meta['width'], $image_meta['height'], $size_array[0], $size_array[1] ) ) {
Expand Down