Disable off option in Autoplay when necessary #84
Conversation
pereirinha
left a comment
pereirinha
left a comment
There was a problem hiding this comment.
I tested the following scenario. While having the Show controls checkbox disabled, I set the Autoplay to Off, and saved the settings. I then checked the Show controls checkbox, and I was able to save the settings while the Autoplay was still Off. I think we should address this scenario.
Also, while reading the task description, I have the feeling it should be the other way around. If we disable the Autoplay and you have the Controls, you should be able to click play. Not sure how you'll be able to do it if you don't have the controls.
...dinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/settings-page.js
Outdated
Show resolved
Hide resolved
...dinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/settings-page.js
Outdated
Show resolved
Hide resolved
dugajean
force-pushed
the
add/355-disable-off-option
branch
from
5a16bc9 to
f5af421
Compare
|
@pereirinha I addressed all your concerns about the logic and feel like this is ready to go now. Demo: https://d.pr/v/0scGc7 |
pereirinha
left a comment
pereirinha
left a comment
There was a problem hiding this comment.
This looks great.
Thank you.
Disable the "off" dropdown option for Autoplay if the player isn't set to Cloudinary or if Show Controls if unchecked.