Fix WPVIP feedback #893
Merged
Fix WPVIP feedback #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 11, 2023 09:09
… that we store the report on uploads folder
DavidCramer
suggested changes
Aug 17, 2023
Contributor
DavidCramer
left a comment
DavidCramer
left a comment
There was a problem hiding this comment.
@pereirinha - It's all cool, but the logic in attachment_url_to_postid is not using the cache.
php/class-utils.php
Outdated
Comment on lines
931
to
934
| if ( 0 === $attachment_id && empty( wp_cache_get( "postid_{$url}", 'cloudinary' ) ) ) { | ||
| $attachment_id = attachment_url_to_postid( $url ); // phpcs:ignore WordPressVIPMinimum.Functions.RestrictedFunctions.attachment_url_to_postid_attachment_url_to_postid | ||
| wp_cache_set( "postid_{$url}", $attachment_id, 'cloudinary' ); | ||
| } |
Contributor
There was a problem hiding this comment.
@pereirinha - You're not actually using the value from wp_cache_get. Perhaps this would be better placed when first defining the var: $attachment_id = wp_cache_get( "postid_{$url}", 'cloudinary' );
Then wrap all the logic in if ! empty
Contributor
Author
There was a problem hiding this comment.
Great catch. Ready for you to circle back ;)
DavidCramer
approved these changes
Aug 22, 2023
Contributor
DavidCramer
left a comment
DavidCramer
left a comment
There was a problem hiding this comment.
@pereirinha - Great stuff! Back to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some warnings seen on WPVIP.
Aside from minor spacing fixes and alike, it also introduces the following:
Utils::attachment_url_to_postid— a wrapper forwpcom_vip_attachment_url_to_postidor usewp_cacheto store this information. This should have a positive impact on performance;export_csvfor the CLI commands, which due to the VIP filesystem, could result in an impossibility of storing the export data;