Special offer #968
Merged
Special offer #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharsheblows
suggested changes
Aug 28, 2024
Contributor
tharsheblows
left a comment
tharsheblows
left a comment
There was a problem hiding this comment.
This is in draft but I have one comment to fix! Otherwise it works well for me.
Great catch ;) Co-authored-by: Mary (JJ) Jay <jjjay@mac.com>
tharsheblows
approved these changes
Aug 28, 2024
Contributor
tharsheblows
left a comment
tharsheblows
left a comment
There was a problem hiding this comment.
There is one comment and that's it! It's very small.
| $args = wp_parse_args( | ||
| $args, | ||
| $default_args | ||
| ); |
Contributor
There was a problem hiding this comment.
👏 praise
I like this approach!
| return sprintf( | ||
| // translators: The HTML markup. | ||
| __( 'We’re compatible with most other plugins so we expect it to work absolutely fine. If you do have any issues, please %1$scontact our support team%2$s who will help resolve your issue.', 'cloudinary' ), | ||
| '<a href="' . Utils::get_support_link() . '" target="_blank" rel="noopener noreferrer">', |
Contributor
There was a problem hiding this comment.
🥜 nitpick
Since there's translated text in the support link, this probably should be escaped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach