Skip to content

Rename auto functions in Quality, add quantization #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2020
Merged

Rename auto functions in Quality, add quantization #202

merged 2 commits into from
Nov 3, 2020

Conversation

@patrick-tolosa
Copy link
Contributor

@patrick-tolosa patrick-tolosa commented Nov 2, 2020

Pull reuqest for @Cloudianry/Base

What does this PR solve?

Align Quality to Spec (add Quantization, and adjust method names)

Final checklist

  • JSdoc - Add proper docstrings based on our PHP implementation
  • JSdoc - Hide private functions using @Private
  • Implementation is aligned to Spec.
  • Tests - Add proper tests to the added code

@patrick-tolosa patrick-tolosa merged commit c27dcab into master Nov 3, 2020
@patrick-tolosa patrick-tolosa deleted the feature/add-quality-quantization branch November 3, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@strausr strausr strausr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@patrick-tolosa @strausr