Skip to content

Conversation

@patrick-tolosa
Copy link
Contributor

Pull reuqest for @Cloudianry/Base

What does this PR solve?

This PR fixes the auto complete issues in VS Code and Webstorm.

The fix was an overhaul of the package we distribute, this is what was done:

  1. Remove all default exports from artificial groups (like Resize)
  2. Remove the types directory, instead, the types are published with the source code in the same structure, this enables much better discovery by IDEs
  3. Remove the ESM directory, we now build the ESM output directly to root.
    4 Due to 3, we can now safely remove a lot of code that was responsible to build our entry points, this is all done organically now.
  4. Adjust all tutorials/examples to make sure they run.

Final checklist

  • Tests - Add proper tests to the added code

@patrick-tolosa patrick-tolosa merged commit 7937fe9 into master Nov 15, 2020
@patrick-tolosa patrick-tolosa deleted the refactor/remove-all-default-exports branch November 15, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants