Skip to content

Add missing tests for URL versions #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Add missing tests for URL versions #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions __TESTS__/unit/urlConfig.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,22 @@ describe('It tests a combination of Cloudinary URL and Configuration', () => {
});
expect(url).toContain('https://something.cloudfront.net/image/upload/');
});
});

it('Generates a URL with version in the public ID', () => {
const img = createNewImage('v1234/foo/sample', {cloudName: 'demo'}, { forceVersion: true});

/**
* http://res.cloudinary.com/{cloudName}
* https://res.cloudinary.com/{cloudName}
* https://{cloudName}-res.cloudinary.com/
* http://{domain}
* https://{domain}
*/
expect(img.toURL()).toContain('https://res.cloudinary.com/demo/image/upload/v1234/foo/sample');
});

it('Generates a URL with V1', () => {
const img = createNewImage('foo/sample', {cloudName: 'demo'}, { forceVersion: true});

expect(img.toURL()).toContain('https://res.cloudinary.com/demo/image/upload/v1/foo/sample');
});

it('Generates a URL without V1', () => {
const img = createNewImage('foo/sample', {cloudName: 'demo'}, { forceVersion: false});

expect(img.toURL()).toContain('https://res.cloudinary.com/demo/image/upload/foo/sample');
});
});