Skip to content

Print to console from parameter #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Print to console from parameter #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ff27a5
MO-821 added the option to print log to console with flag
orenCloudinary Jul 26, 2022
8a4d250
added the flag to the logger
orenCloudinary Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
.DS_Store
.idea
*.iml
node_modules
/.vscode/

build
*.log*
node_modules
npm-debug.log

*.iml
*.log*
.history

# Elastic Beanstalk Files
.elasticbeanstalk/*
!.elasticbeanstalk/*.cfg.yml
!.elasticbeanstalk/*.global.yml
.env

2 changes: 1 addition & 1 deletion logger/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const logger = new Rollbar({
},
});

if ('development' === process.env.NODE_ENV) {
if ('development' === process.env.NODE_ENV || 'true' === process.env.PRINT_LOGS_CONSOLE) {
logger.configure({verbose: true});
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"async": "^3.2.0",
"body-parser": "~1.19.0",
"bytes": "^3.1.0",
"cloudinary": "^1.28.1",
"cloudinary": "https://github.com/cloudinary/cloudinary_npm.git#analyze_api_legacy",
Copy link

@IdanL-Cloudinary IdanL-Cloudinary Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using a tag of the repository and not a branch because people might commit to that branch

"config": "^3.3.6",
"cookie-parser": "~1.4.5",
"debug": "~4.3.1",
Expand Down