Skip to content

Commit 337cd2b

Browse files
yuchen-96wkozaczuk
authored andcommitted
osv: properly assign gsi number inside handler
Initialize the gsi number inside handler to an unreachable number. The gsi number was not properly initialized and default to 0 previously, and caused interrupt misfiring for level triggered interrupts on pin 0 when it checks for the gsi number for interrupt sharing. This commit fixed the misfiring on pin 0. Fixes: 5fc9daf ("interrupt: Support interrupt sharing") Signed-off-by: YuChen Qian <yuchenq@amazon.de> Reviewed-by: Amadeusz Juskowiak <ajusk@amazon.de> Reviewed-by: Marius Hillenbrand <mhillenb@amazon.de> Cc-Team: kaos-brimstone <kaos-brimstone@amazon.com> CR: https://code.amazon.com/reviews/CR-14472907 Message-Id: <20191204084413.5400-1-yuchenq@amazon.de>
1 parent 35c85d0 commit 337cd2b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

arch/x64/exceptions.hh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ private:
117117
break;
118118
}
119119
}
120+
gsi = -1u;
120121
}
121122

122123
handler(handler *h,
@@ -131,6 +132,7 @@ private:
131132
ids.push_back(id++);
132133
pre_eois.push_back(_pre_eoi);
133134
post_eois.push_back(_post_eoi);
135+
gsi = -1u;
134136
}
135137

136138
unsigned size()

0 commit comments

Comments
 (0)