Skip to content

Commit fe61b31

Browse files
wkozaczuknyh
authored andcommitted
external x64: remove gcc.bin
This patch in essence changes skel manifests to pull libgcc_s.so from host instead of gcc.bin under externals. It also removes external/x64/gcc.bin module. References #743 Signed-off-by: Waldemar Kozaczuk <jwkozaczuk@gmail.com> Message-Id: <20200122032153.6195-4-jwkozaczuk@gmail.com>
1 parent 2b3bac5 commit fe61b31

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

.gitmodules

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
[submodule "external/x64/gcc.bin"]
2-
path = external/x64/gcc.bin
3-
url = ../../cloudius-systems/gcc.bin
4-
ignore = dirty
51
[submodule "external/x64/acpica"]
62
path = external/x64/acpica
73
url = ../../cloudius-systems/acpica

Makefile

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1923,10 +1923,16 @@ $(bootfs_manifest_dep): phony
19231923
echo -n $(bootfs_manifest) > $(bootfs_manifest_dep) ; \
19241924
fi
19251925

1926+
ifeq ($(arch),x64)
1927+
libgcc_s_dir := $(dir $(shell $(CC) -print-file-name=libgcc_s.so.1))
1928+
else
1929+
libgcc_s_dir := ../../$(gccbase)/lib64
1930+
endif
1931+
19261932
$(out)/bootfs.bin: scripts/mkbootfs.py $(bootfs_manifest) $(bootfs_manifest_dep) $(tools:%=$(out)/%) \
19271933
$(out)/zpool.so $(out)/zfs.so $(out)/libenviron.so $(out)/libvdso.so
19281934
$(call quiet, olddir=`pwd`; cd $(out); "$$olddir"/scripts/mkbootfs.py -o bootfs.bin -d bootfs.bin.d -m "$$olddir"/$(bootfs_manifest) \
1929-
-D gccbase="$$olddir"/$(gccbase), MKBOOTFS $@)
1935+
-D libgcc_s_dir=$(libgcc_s_dir), MKBOOTFS $@)
19301936

19311937
$(out)/bootfs.o: $(out)/bootfs.bin
19321938
$(out)/bootfs.o: ASFLAGS += -I$(out)

scripts/build

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,6 @@ aarch64) image=${vars[image]-uush};;
169169
esac
170170
modules=${vars[modules]-!$image}
171171

172-
# TODO: some modules need these... Would be better if they wouldn't...
173-
gccbase=${vars[gccbase]-"$SRC"/external/$arch/gcc.bin}
174-
175172
case $OUT in
176173
/*) OSV_BUILD_PATH=$OUT;;
177174
*) OSV_BUILD_PATH=`pwd`/$OUT;;
@@ -256,6 +253,7 @@ kernel_end=$(($loader_size+2097151 & ~2097151))
256253
# the case in our old build.mk).
257254
cd $OUT
258255

256+
libgcc_s_dir=$(dirname $(readlink -f $(gcc -print-file-name=libgcc_s.so.1)))
259257
case $fs_type in
260258
zfs)
261259
cp loader.img bare.raw
@@ -267,15 +265,15 @@ zfs)
267265

268266
if [ "$export" == "none" ]
269267
then
270-
"$SRC"/scripts/upload_manifest.py -o usr.img -m usr.manifest -D gccbase="$gccbase"
268+
"$SRC"/scripts/upload_manifest.py -o usr.img -m usr.manifest -D libgcc_s_dir="$libgcc_s_dir"
271269
else
272270
export_dir=${vars[export_dir]-$SRC/build/export}
273-
"$SRC"/scripts/export_manifest.py -e "$export_dir" -m usr.manifest -D gccbase="$gccbase"
271+
"$SRC"/scripts/export_manifest.py -e "$export_dir" -m usr.manifest -D libgcc_s_dir="$libgcc_s_dir"
274272
fi
275273
;;
276274
rofs)
277275
rm -rf rofs.img
278-
"$SRC"/scripts/gen-rofs-img.py -o rofs.img -m usr.manifest -D gccbase="$gccbase"
276+
"$SRC"/scripts/gen-rofs-img.py -o rofs.img -m usr.manifest -D libgcc_s_dir="$libgcc_s_dir"
279277
rofs_size=`stat --printf %s rofs.img`
280278
img_size=$((kernel_end + rofs_size))
281279
cp loader.img bare.raw

usr.manifest.skel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
/tools/cpiod.so: tools/cpiod/cpiod.so
1010
/tools/mount-nfs.so: tools/mount/mount-nfs.so
1111
/tools/umount.so: tools/mount/umount.so
12-
/usr/lib/libgcc_s.so.1: %(gccbase)s/lib64/libgcc_s.so.1
12+
/usr/lib/libgcc_s.so.1: %(libgcc_s_dir)s/libgcc_s.so.1
1313
/&/etc/hosts: ../../static/&
1414
/etc/mnttab: ->/proc/mounts
1515
/&/etc/fstab: ../../static/&

usr_ramfs.manifest.skel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
/libvdso.so: libvdso.so
44
/tools/mount-nfs.so: tools/mount/mount-nfs.so
55
/tools/umount.so: tools/mount/umount.so
6-
/usr/lib/libgcc_s.so.1: %(gccbase)s/lib64/libgcc_s.so.1
6+
/usr/lib/libgcc_s.so.1: %(libgcc_s_dir)s/libgcc_s.so.1
77
/&/etc/hosts: ../../static/&
88

99
/etc/mnttab: ->/proc/mounts

usr_rofs.manifest.skel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
/libvdso.so: libvdso.so
44
/tools/mount-nfs.so: tools/mount/mount-nfs.so
55
/tools/umount.so: tools/mount/umount.so
6-
/usr/lib/libgcc_s.so.1: %(gccbase)s/lib64/libgcc_s.so.1
6+
/usr/lib/libgcc_s.so.1: %(libgcc_s_dir)s/libgcc_s.so.1
77
/&/etc/hosts: ../../static/&
88

99
/etc/mnttab: ->/proc/mounts

0 commit comments

Comments
 (0)