Feature/plain selenium build lib #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Selenium documentation tells us (if we want to check if hub is available) that we should consult the `value.ready` object rather than waiting for `status` to be zero. The status indicates the plain availability of the hub while `ready` indicates if the hub has actual capacity to start any tests, that is if any are readily available. Signed-off-by: Philipp Pixel <pixeloffice@philipppixel.de>
Job names are often used to create job-unique identifiers. In turn these identifiers do also serve for docker container names which may lead to DNS names. DNS names should not contain underscores. Signed-off-by: Philipp Pixel <pixeloffice@philipppixel.de>
The docker network should only be specified when it exists. Otherwise the build step will fail.
If there is no network passed to selenium a default network will be created. This network is used to establish the communication between selenium grid hub and its nodes with the container name of the grid hub.
Previously the path was hard coded.
In addition, the usage description was updated so it shows how selenium can be configured.
ppxl
requested changes
Feb 10, 2020
…d update documentation
ppxl
reviewed
Feb 12, 2020
Member
ppxl
left a comment
ppxl
left a comment
There was a problem hiding this comment.
only slight items arise here, mainly non-functional things like wording of comments, or newlines. I'll fix it and than we're through.
Signed-off-by: Philipp Pixel <pixeloffice@philipppixel.de>
Signed-off-by: Philipp Pixel <pixeloffice@philipppixel.de>
Signed-off-by: Philipp Pixel <pixeloffice@philipppixel.de>
Previously the signature of `settings()` was modified to contain a maven repo name. This would be a breaking change. This new parameter was now retrofitted with a senseful default so it still could work out. Furthermore: Doc-o-rama Signed-off-by: Philipp Pixel <pixeloffice@philipppixel.de>
In some cases the use of `toArray` is forbidden.
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the plain selenium feature to run e2e tests without zalenium.
resolves #7