Skip to content

Conversation

@disq
Copy link
Member

@disq disq commented Jun 23, 2023

ready to merge as of 4.8.0-rc1

BEGIN_COMMIT_OVERRIDE
feat!: Upgrades the test source plugin to use plugin-sdk v4. This version contains no user-facing breaking changes, but because it is now using CloudQuery gRPC protocol v3, it does require use of a destination plugin that also supports protocol v3. All recent destination plugin versions support this.
END_COMMIT_OVERRIDE

Closes #11748

@disq disq force-pushed the v4-test-source branch from deec03d to 22ff21a Compare June 23, 2023 12:49
@disq disq linked an issue Jun 26, 2023 that may be closed by this pull request
@disq disq marked this pull request as ready for review June 30, 2023 15:31
@disq disq requested review from a team and bbernays and removed request for a team June 30, 2023 15:31
Copy link
Collaborator

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but then again I haven't really been involved with V4 at all...

@disq disq added the automerge Automatically merge once required checks pass label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate plugins/source/test to github.com/cloudquery/plugin-sdk/v4

4 participants