Merged
Conversation
disq
commented
Feb 3, 2023
erezrokah
approved these changes
Feb 6, 2023
yevgenypats
approved these changes
Feb 7, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good! I didn't test so don't know the in-and-outs of parquet as of now (and thus didn't have any major questions, thoughts), will let users play with it and maybe also give it a try later on.
Looks like parquet-go doesn't handle the `uuid` tag correctly
erezrokah
force-pushed
the
feat/parquet-format-2
branch
from
ea6b9c9 to
27b9438
Compare
kodiakhq Bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [1.4.0](v1.3.2...v1.4.0) (2023-02-07) ### Features * Parquet format (take 2) ([#59](#59)) ([b331ef6](b331ef6)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.33.1 ([#57](#57)) ([b6bb501](b6bb501)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.34.0 ([#60](#60)) ([2866fa0](2866fa0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like #50 but uses https://github.com/xitongsys/parquet-go instead of https://github.com/segmentio/parquet-go