-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Link to latest version on 404 hub downloads #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
erezrokah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 I know this is still in draft, but added a couple of non blocking comments regarding error handling. Please let me know what you think
|
@dcelasun have you been able to test this with the binary? I'm double-checking here because I'm not seeing the error: Before patching with your latest commit After Double-checking here still in case I did something wrong while testing |
See comment for rationale
Fixed by the latest commit, though I'm not sure if that's the cleanest approach. One idea is to pull the version check to its own function, before Open to suggestions. |
🤖 I have created a release *beep* *boop* --- ## [1.25.0](v1.24.1...v1.25.0) (2024-10-23) ### Features * Link to latest version on 404 hub downloads ([#423](#423)) ([b4ca098](b4ca098)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This fixes https://github.com/cloudquery/cloudquery-issues/issues/616
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmt ./...to format your code 🖊golangci-lint run🚨 (install golangci-lint here)