fix(batchwriter): Allow zero batch size, flush before exceeding batch size instead of after #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… size instead of after
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 48.04% 48.01% -0.03%
==========================================
Files 74 74
Lines 7129 7125 -4
==========================================
- Hits 3425 3421 -4
Misses 3392 3392
Partials 312 312
☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
Jun 28, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0-rc1](v4.1.0-rc1...v4.2.0-rc1) (2023-06-28) ### Features * Add StreamingBatchWriter ([#1004](#1004)) ([986340f](986340f)) ### Bug Fixes * **batchwriter:** Allow zero batch size, flush before exceeding batch size instead of after ([#1008](#1008)) ([c7ea17b](c7ea17b)) * Naming fix for `messages.InsertMessage` (now `messages.GetInserts`) ([#1000](#1000)) ([b1e2bd4](b1e2bd4)) * Update scheduler for JSON marshal / unmarshal ([#1006](#1006)) ([970bad1](970bad1)) * **writers:** Move to sub packages ([#1011](#1011)) ([826e816](826e816)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.