fix: DeleteStale feature #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
reviewed
Oct 10, 2022
disq
reviewed
Oct 10, 2022
disq
approved these changes
Oct 10, 2022
1) Before this PR the "indexing" was done on a copy of the table rather than the actual table.. 2) Because a new 'once' object is created at every invocation of 'ColumnIndex', it doesn't actually happen "once". Nor does it provide protection from race-conditions in case of concurrent calls. 3) The method is unused..
Move responsibility for migrating the cq_sync_time and cq_source_name columns to the destination plugin. We do this because the source plugins don't really care about these columns (it's an implementation detail of 'overwriteDeleteStale'.
yevgenypats
suggested changes
Oct 10, 2022
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Looks great! Let's just not change receiver to *table as I recall there were reasons for why it is not pointer receiver. let's keep it table and maybe open an issue to look into making it pointer receiever in the future but it will need to take special care of.
yevgenypats
approved these changes
Oct 10, 2022
shimonp21
pushed a commit
that referenced
this pull request
Oct 10, 2022
🤖 I have created a release *beep* *boop* --- ## [0.13.0](v0.12.10...v0.13.0) (2022-10-10) ### ⚠ BREAKING CHANGES * Support table_concurrency and resource_concurrency (#268) ### Features * Support table_concurrency and resource_concurrency ([#268](#268)) ([7717d6f](7717d6f)) ### Bug Fixes * Add custom log reader implementation to fix hang on long log lines ([#263](#263)) ([f8ca238](f8ca238)) * DeleteStale feature ([#269](#269)) ([837c5f3](837c5f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Oct 11, 2022
…re) (#2587) #### Summary This will only compile after cloudquery/plugin-sdk#269 is released <!-- Explain what problem this PR addresses --> <!--
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
testing matrix (two syncs, different versions for first and second sync )
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)