fix: SourceName #262
Closed
fix: SourceName #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
suggested changes
Oct 7, 2022
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
looks good but I think there is a bug
| for r := range res { | ||
| if _, ok := r.Data[schema.CqSourceName.Name]; ok { | ||
| r.Data[schema.CqSourceName.Name] = source | ||
| if _, ok := r.Data[schema.CqSourceName.Name]; !ok { |
Contributor
There was a problem hiding this comment.
why this is changed from ok to !ok ? if it doesn't exist it all then the write query will fail because this column wasn't migrated. but it should just be there and be nil and we should overwrite it.
Contributor
Author
|
replaced by #269 |
auto-merge was automatically disabled
October 10, 2022 08:31
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)