fix(types-timestamp): Ensure timestamp is UTC #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark resultsComparing with d0c2e26
|
candiduslynx
approved these changes
Feb 28, 2023
yevgenypats
approved these changes
Mar 2, 2023
erezrokah
force-pushed
the
fix/timestamp_utc
branch
from
1ff9eae to
aa65add
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
=======================================
Coverage 48.81% 48.81%
=======================================
Files 70 70
Lines 6892 6887 -5
=======================================
- Hits 3364 3362 -2
+ Misses 3063 3061 -2
+ Partials 465 464 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
🤖 I have created a release *beep* *boop* --- ## [1.41.0](v1.40.0...v1.41.0) (2023-03-02) ### Features * Deterministic _cq_id ([#712](#712)) ([2e7ad2c](2e7ad2c)) * **multiplex:** Detect duplicated clients ([#723](#723)) ([dfb039d](dfb039d)) ### Bug Fixes * Cleanup code ([#710](#710)) ([963f03c](963f03c)) * **deps:** Update golang.org/x/exp digest to c95f2b4 ([#718](#718)) ([de52c10](de52c10)) * **deps:** Update google.golang.org/genproto digest to 9b19f0b ([#719](#719)) ([ecfddea](ecfddea)) * **deps:** Update module github.com/rivo/uniseg to v0.4.4 ([#720](#720)) ([0da69b6](0da69b6)) * **deps:** Update module github.com/stretchr/testify to v1.8.2 ([#721](#721)) ([19c0742](19c0742)) * **pk:** Skip filter for no PK ([#709](#709)) ([d0c2e26](d0c2e26)) * **types-json:** Disable HTML escaping during JSON marshalling ([#714](#714)) ([2f6f1d8](2f6f1d8)) * **types-timestamp:** Ensure timestamp is UTC ([#716](#716)) ([bb33629](bb33629)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #700
Tested this on quite a few plugins. Most send
time.Timein UTC already (nillocation).The only impact I've seen is on this AWS resource:
https://github.com/cloudquery/cloudquery/blob/380bcddff9406d12b7de343dd4dd002c95b46f0f/plugins/source/aws/resources/services/iam/credential_reports_fetch.go#L66
which for some reason results in a
time.Timewith a location with an empty name, so that would be converted to UTC.Another impact is on the Stripe plugin that uses
int64. Sincetime.Unixreturns atime.Timewith local timezone, now it will be converted toUTC.Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)