fix(testing): Add sorting for testing dest migrations #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark results
|
hermanschaaf
approved these changes
Apr 20, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
=======================================
Coverage 46.65% 46.65%
=======================================
Files 76 76
Lines 7823 7823
=======================================
Hits 3650 3650
Misses 3682 3682
Partials 491 491 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
disq
reviewed
Apr 20, 2023
| records = append(records, bldr.NewRecord()) | ||
| bldr.Release() | ||
| } | ||
| if indices := sc.FieldIndices(schema.CqIDColumn.Name); len(indices) > 0 { |
erezrokah
pushed a commit
that referenced
this pull request
Apr 20, 2023
🤖 I have created a release *beep* *boop* --- ## [2.3.8](v2.3.7...v2.3.8) (2023-04-20) ### Bug Fixes * Fail on empty tables ([#796](#796)) ([1320d32](1320d32)) * **testing:** Add sorting for testing dest migrations ([#814](#814)) ([b1437f1](b1437f1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some flakey tests for destination and also fix germlin - cloudquery/cloudquery#10188